[Core] Fail with non-zero exit code when using unsupported features #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Jan 7, 2025
| @@ -2918,6 +2919,7 @@ def _down_or_stop(name: str): | |||
| except (exceptions.NotSupportedError, | |||
| exceptions.ClusterNotUpError) as e: | |||
| message = str(e) | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
We don't want a failure for a single cluster to abort the termination for the other clusters. Since we are running the terminations in parallel, how about we gather all the failures and show them in a table at the end and return non-zero for any failure happens during the termination at the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2775.
bash format.sh