Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect device motion #156

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Detect device motion #156

merged 3 commits into from
Nov 1, 2024

Conversation

WebSpider
Copy link
Contributor

Fixes #148

dvx76
dvx76 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@dvx76 dvx76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to perform a real-world test if you haven't already.

@WebSpider
Copy link
Contributor Author

I havent already, good idea. Just tested it still works when positioning is disabled 😆

@WebSpider
Copy link
Contributor Author

Just tested it in real-world, and it works. Will add a few more translation strings I found and merge.

@WebSpider WebSpider merged commit 2dfa834 into skodaconnect:main Nov 1, 2024
3 checks passed
@WebSpider WebSpider deleted the motion-detection branch November 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvx76 dvx76 dvx76 approved these changes

@Prior99 Prior99 Awaiting requested review from Prior99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle vehicle in motion
2 participants
@WebSpider @dvx76