Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value of charge_type sensor #152

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix value of charge_type sensor #152

merged 2 commits into from
Oct 31, 2024

Conversation

WebSpider
Copy link
Contributor

Currently, the value of the charge_type sensor is always a string, reporting "none" when no charging is happening.

This changes the behaviour to:

  • Lowercase value ac/dc/off when we get a reply
  • Unknown when we do not get a reply
  • Adds translation for ac/dc/off

@WebSpider WebSpider requested a review from dvx76 October 31, 2024 11:50
@WebSpider WebSpider merged commit 7d0df80 into skodaconnect:main Oct 31, 2024
3 checks passed
@WebSpider WebSpider deleted the fix-chargetype-none branch October 31, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvx76 dvx76 dvx76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebSpider @dvx76