Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to new actions. #29

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Refactor to new actions. #29

merged 7 commits into from
Jan 16, 2025

Conversation

lexbritvin
Copy link
Contributor

No description provided.

@davidferlay
Copy link
Contributor

davidferlay commented Jan 3, 2025

Looks like this branch is lacking some of the latest changes merged in main branch:

Helper is a good indication that bits are missing.
Currently:

Meta: Executes bump + compose + sync + package + publish + deploy

Usage:
  plasmactl meta environment tags [flags]

Aliases:
  meta, deliver

Flags:
      --ci                CI: Execute all commands and deploy in CI
      --clean             Clean: Clean flag for local compose command
      --last              Last: Last flag for local bump command
      --override string   Override: Bump --sync override option
      --skip-bump         Skip bump: Skip execution of local bump command

Expected:

➜  ski-collaborate git:(master) ./plasmactl meta --help
Push code + bump and deploy in CI (compose + sync + package + publish + deploy)

Usage:
  plasmactl meta [flags] environment tags

Aliases:
  meta, deliver

Flags:
      --ci                    Deprecated option (now default bebavior)
      --clean                 Clean flag for local compose command (only with --local)
      --conflicts-verbosity   Log files conflicts during composition
      --debug                 Run Ansible in debug mode
  -h, --help                  help for meta
      --last                  Last flag for local bump command
      --local                 Execute compose + sync + package + publish + deploy locally instead of using CI
      --skip-bump             Skip execution of bump command

Can you please rebase this branch and include latest changes from main @lexbritvin ?

@lexbritvin
Copy link
Contributor Author

lexbritvin commented Jan 8, 2025

Rebased

}

return command
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: make sure pw is not shown when executed sub commands are printed

return handleCmdErr(syncErr, "sync error")
err = p.executeAction(ctx, "bump", nil, action.InputParams{
"sync": true,
})
Copy link
Contributor

@davidferlay davidferlay Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add option --show-progress by default ?
However, option should not be used if user is using any log level -v

@lexbritvin lexbritvin merged commit 9bb3486 into main Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants