NEXT theme type improvements #2549
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AdrianGonz97 @ryceg @Hugos68 tagging you for review on this as you guys are our resident Typescript pros. The changes are fairly simple, so hopefully nothing too egregious here! Just FYI I do expect us to add a few additional properties between now and launch. But I'll do my best to ensure those are addressed evenly between all v3 themes. As well as take care to update the type along the way. I also have |
| @@ -1,4 +1,4 @@ | |||
| import type { PresetTheme } from '../index.js'; | |||
| // import type { Theme } from '../index.js'; | |||
|
|
|||
| const goldNouveau = { | |||
There was a problem hiding this comment.
I think an extension of Theme that had lines 6 through 19 would be a good idea, so that the themes are typechecked
There was a problem hiding this comment.
I don't think GitHub is aligning this message in the right place, but if you're referring to the properties_dark and enhancements - those aren't carrying over to v3!
Co-authored-by: Rhys <[email protected]>
|
Was asleep but looks good 😁 |
Linked Issue
#2360
Description
Consolidates the preset and custom theme types into a single
Themetype. Removesproperties_darkandenhancementsfrom the type. Updates thepropertiesto match the current v3 structure.