feat/autocomplete-custom-filter-function

[Mahmoud-zino]

Linked Issue

Closes #1966

Description

Added prop filterFunction with default value of the Skeleton's original filter function.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

🦋 Changeset detected

Latest commit: 467134e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@skeletonlabs/skeleton	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	Nov 8, 2023 0:09am

[endigo9740]

@Mahmoud-zino a couple things on this:

1. Go ahead and rename the prop filter (one word). We should aim to keep props as slim as possible.
2. I'm not sure I understand what the sentence in the example is referring to - highlighted here:

This example uses a custom filter to filter options after value only.

The other examples just show the filtered results - maybe we just go ahead and follow that pattern here? That or just remove this line. I think what's present works fine.

If you can make these couple changes then this should be good to merge.

[Mahmoud-zino]

@endigo9740
the line was intended to convey that the filter is different from the standard one. The standard filter applies after value, label, or keyword filtering while the modified one filters only after value. However, I recognize that it might be more confusing than helpful for users to understand its meaning, so I will remove it

[endigo9740]

@Mahmoud-zino looks good. Be sure to flip to "ready to review" when you're done.