-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/filter-contributors-list #2207
docs/filter-contributors-list #2207
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FYI PR audits will be on Saturday or Sundays going forward, so expect a proper review then. I noted the old list is still displayed and the grid of icons is wrapping, so if that's something you want me to take a look at just let me know! |
@endigo9740 I just displayed them in a very similar way like it was, I am not very creative when it comes to designing and laying stuff out so yeah please go ahead and change it like you prefer 👍 |
Ok, I see what you did here, you spliced the set into two groups. For some reason I thought both were the same people in my prior review. I think the vertical stack is really the only way to handle this many people, but I'm not sure I like emphasizing one group more than another so I've made everyone the same size. Everyone that contributes is equally important to me :) |
@endigo9740 Well, I didn't intend to diminish anyone's contribution 😄. However, you mentioned in the request that we might want to include the rest of the contributors with smaller sizes, so that's what I did 😄. |
Not at all. Sometimes things are different when you see them implemented. I definitely think this is the way to go. |
Linked Issue
Closes #2106
Description
filter out mentioned contributors.
display up to 100 contributors.
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages/skeleton
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm check
pnpm format
pnpm test