Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/filter-contributors-list #2207

Merged

Conversation

Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #2106

Description

filter out mentioned contributors.
display up to 100 contributors.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: 2117dbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Nov 5, 2023 4:39pm

@endigo9740
Copy link
Contributor

FYI PR audits will be on Saturday or Sundays going forward, so expect a proper review then. I noted the old list is still displayed and the grid of icons is wrapping, so if that's something you want me to take a look at just let me know!

@Mahmoud-zino
Copy link
Contributor Author

@endigo9740 I just displayed them in a very similar way like it was, I am not very creative when it comes to designing and laying stuff out so yeah please go ahead and change it like you prefer 👍

@endigo9740
Copy link
Contributor

endigo9740 commented Nov 5, 2023

Ok, I see what you did here, you spliced the set into two groups. For some reason I thought both were the same people in my prior review. I think the vertical stack is really the only way to handle this many people, but I'm not sure I like emphasizing one group more than another so I've made everyone the same size. Everyone that contributes is equally important to me :)

@endigo9740 endigo9740 merged commit 83a2a4d into skeletonlabs:dev Nov 5, 2023
3 checks passed
@Mahmoud-zino
Copy link
Contributor Author

@endigo9740 Well, I didn't intend to diminish anyone's contribution 😄. However, you mentioned in the request that we might want to include the rest of the contributors with smaller sizes, so that's what I did 😄.

@endigo9740
Copy link
Contributor

Not at all. Sometimes things are different when you see them implemented. I definitely think this is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter GitHub sponsor users list on the homepage
2 participants