Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/list wrapping #2200

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

SebasF1349
Copy link
Member

Linked Issue

Closes #2198

Description

Fix to lists not wrapping.

Note: As whitespace-normal is the default behaviour, looks like it's not even necessary to specify it, but I add it to be consistent with .list li styles.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2023

🦋 Changeset detected

Latest commit: 15a2ecd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/tw-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Nov 6, 2023 0:52am

@endigo9740
Copy link
Contributor

@SebasF1349 I see you went with break-words instead of break-spaces per the original suggestion. Any reason for that? I know long words can be troublesome, but this might impact readability. Let me know, and we'll aim to merge once that's sorted.

@endigo9740 endigo9740 marked this pull request as draft November 5, 2023 16:48
@SebasF1349
Copy link
Member Author

I guess you meant whitespace-break-spaces instead of break-spaces, which was the suggestion in the issue, but it adds space between the dt and the dd

chrome_D1ow6cBAjV

Unless you meant break-all, which I don't have an objection to.

In any case, I added both whitespace-normal and break-words to keep consistency with the styles in .list li in the same file.

@endigo9740
Copy link
Contributor

Whatever provides the results shown in the original post, but without splitting mid-word please!

@SebasF1349
Copy link
Member Author

Fixed removing the classes altogether, as that's the normal behaviour (break-normal and whitespace-normal)

@endigo9740 endigo9740 marked this pull request as ready for review November 7, 2023 23:59
@endigo9740 endigo9740 merged commit 2f56c03 into skeletonlabs:dev Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description List content overflow
2 participants