Feat/paginator-optional-size

[Mahmoud-zino]

Linked Issue

Closes #2066

Description

when the size is optional, all controls depending on it are hidden.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

🦋 Changeset detected

Latest commit: 06b2107

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@skeletonlabs/skeleton	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	Oct 26, 2023 6:39pm

[endigo9740]

@Mahmoud-zino it looks like we hav a bug. In fact, I'm not sure how we'll overcome this. But when no size is present we don't know the max range, so you can just navigate to the next page forever. Well beyond the limit of the content itself.

I think we may just want to trust our gut on this one and make the recommendation that we don't support pagination without a size defined. Even if the end users have to query this separately, they should be able to know the max number of items, which is crucial for pagination to work at all. I've visualized the issue below:

Without a size defined, we don't know when to quit showing new "groups" of items.

Unless you can come up with a better solution, I'll go ahead and close this and respond in the original thread.

[Mahmoud-zino]

@endigo9740 I noticed this when testing but I didn't consider it a bug because if the size is not known, it should be expected that we can't limit the paginator.
With that being said, I can see why this could cause us more trouble than benefits and I agree that we should not implement it. 😄

[endigo9740]

@Mahmoud-zino yeah this will look and feel busted to end users. They won't understand why this occurring since there's no indicator they've reached the end of the content.