Bugfix/tree view flow bugs #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4f8d008 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @Mahmoud-zino I'll try to get a review in tomorrow if time allows! |
|
@endigo9740 I think you missed this in the last release, there were some conflicts from the other PR so I fixed them. |
|
@Mahmoud-zino nah I'd mentioned I'd merge if I had time to review, but unfortunately that did not end up being the case. This is merged now and will be part of the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #2145
Closes #2144
Description
@endigo9740
FYI, I didn't go with the readonly-way (it is too complicated and I will have to invent svelte5 inside a component which is not realistic), instead of that the component now just expects a correct array in relational mode when changing the checkedNodes programmatically,
this means when the user wants to check a child programmatically, the user must also include its parent in the checkedNodes array etc..., this makes managing the relations a lot easier (no more magic needed) but it let's the user shoot their foots if they wanted to 😄.
@Sarenor If this PR get's accepted, I expect you to answer a ton of questions on the behaviour above so I wanted to mention you as well 😅
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages/skeleton, runpnpm changesetin the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminorwhile chores and bugfixes should bepatch. Please prefix the changeset message withfeat:,bugfix:orchore:.Checklist
Please read and apply all contribution requirements.
devbranch (NEVERmaster)docs/,feat/,chore/,bugfix/pnpm checkpnpm formatpnpm test