Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popup warning #2149

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

codercatdev
Copy link
Contributor

Linked Issue

Closes #2148

Description

I was stuck for a while on this and finally realized that it was just the display override because of using flex on the [data-popup] div.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 8865664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Oct 20, 2023 3:42pm

@endigo9740
Copy link
Contributor

@codercatdev seems like a good warning to add. I might adjust the formatting a bit, but otherwise I'd expect we'll move forward with this. Thanks!

My PR reviews are typically on Fridays, so look for updates later this week.

@endigo9740
Copy link
Contributor

@codercatdev This solves a very real issue that had I had completely missed!

Please note I've pushed a small change that helps bring this in line with our standard doc paradigms and tone:

  • Doc info is provided in a "story" format. We install, show basic usage, then provide warnings. So this made most sense in the latter category.
  • I've rewritten the text to bring it in line with our standard writing style
  • Removed the .alert class
  • Made minor adjustments to the code block snippets to help explain the issue and solution.

Overall this is a great addition. I appreciate your contribution!

@endigo9740 endigo9740 merged commit 2710639 into skeletonlabs:dev Oct 20, 2023
@codercatdev
Copy link
Contributor Author

@endigo9740 glad it helped! If you ever want to come on the pod with Britt and I lmk.

https://codingcat.dev/podcasts

@endigo9740
Copy link
Contributor

@codercatdev Alex that's super kind offer. Unfortunately I'm juggling like a million things in my personal life right now and my schedule is an absolute disaster. Once things chill a bit I'd love to take you up on that offer though! I think that would be a blast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about popup to not override display
3 participants