-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add popup warning #2149
add popup warning #2149
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@codercatdev seems like a good warning to add. I might adjust the formatting a bit, but otherwise I'd expect we'll move forward with this. Thanks! My PR reviews are typically on Fridays, so look for updates later this week. |
@codercatdev This solves a very real issue that had I had completely missed! Please note I've pushed a small change that helps bring this in line with our standard doc paradigms and tone:
Overall this is a great addition. I appreciate your contribution! |
@endigo9740 glad it helped! If you ever want to come on the pod with Britt and I lmk. |
@codercatdev Alex that's super kind offer. Unfortunately I'm juggling like a million things in my personal life right now and my schedule is an absolute disaster. Once things chill a bit I'd love to take you up on that offer though! I think that would be a blast! |
Linked Issue
Closes #2148
Description
I was stuck for a while on this and finally realized that it was just the display override because of using flex on the
[data-popup]
div.Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages/skeleton
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm check
pnpm format
pnpm test