Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the option to configure when the action should start reporting a new version #910

Merged
merged 31 commits into from
May 25, 2023

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Apr 9, 2023

Closes #880

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

Merging #910 (f7337cd) into master (415a801) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #910   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        21    +3     
  Lines          225       271   +46     
  Branches        36        52   +16     
=========================================
+ Hits           225       271   +46     
Impacted Files Coverage Δ
src/issue-management.ts 100.00% <100.00%> (ø)
src/outdated-beta.ts 100.00% <100.00%> (ø)
src/outdated-rc.ts 100.00% <100.00%> (ø)
src/outdated-stable.ts 100.00% <100.00%> (ø)
src/run.ts 100.00% <100.00%> (ø)
src/up-to-date.ts 100.00% <100.00%> (ø)
src/wordpress-versions.ts 100.00% <100.00%> (ø)
src/wpvc-config.ts 100.00% <100.00%> (ø)

@jeffpaul
Copy link

Nice! It may be worth an update in [README.md](https://github.com/skaut/wordpress-version-checker#readme) as well to note the channel option.

@marekdedic marekdedic marked this pull request as ready for review April 11, 2023 20:03
@marekdedic
Copy link
Contributor Author

Hey, @jeffpaul, could you please a look at this? I get that you possibly won't understand all the details, but I'd like to know if it passes the smell test and does what you'd want as the original reporter... Thanks!

@marekdedic
Copy link
Contributor Author

Also, the roadmap:

  • If this looks OK, I'll merge it and release it as a new minor version
  • Once betas/RCs for WordPress 6.3 start rolling, I can add support for the beta channel (Enabled support for the beta channel #915) and release that as a new minor version
  • Concurrently with that, I'd like to switch the default channel to RC and release that as a new major version (Set the default channel to RC #916)

README.md Show resolved Hide resolved
@marekdedic marekdedic merged commit d16a95c into master May 25, 2023
@marekdedic marekdedic deleted the configurable-channel branch May 25, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional flag to check at Release Candidate phase
3 participants