Skip to content

Commit

Permalink
Merge pull request #916 from skaut/default-rc-channel
Browse files Browse the repository at this point in the history
Set the default channel to RC
  • Loading branch information
marekdedic authored Aug 30, 2023
2 parents bc6165d + 1d5463f commit 0217da4
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ By default, the app checks for readme in `readme.txt` and `plugin/readme.txt`. I

### WordPress release channel

By default, the app will only notify you once the new WordPress version is released (**This will change** - starting from version 2.0, the default value will be changed to `rc`). By setting the `channel` value to one of `stable`, `rc` or `beta`, you can choose to be notified when the new version is fully release, is in the release candidate (RC) stage of development or when the first beta versions are released.
By default, the app will notify you once the an upcoming WordPress version reaches the release candidate stage of development. By setting the `channel` value to one of `stable`, `rc` or `beta`, you can choose to be notified when the new version is fully released, is in the release candidate (RC) stage of development, or when the first beta versions are released respectively.

#### Example

Expand Down
4 changes: 2 additions & 2 deletions __tests__/wpvc-config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe("Mocked env variables", () => {

await expect(WPVCConfig()).resolves.toStrictEqual({
readme: ["readme.txt", "plugin/readme.txt"],
channel: "stable",
channel: "rc",
assignees: [],
});
});
Expand All @@ -87,7 +87,7 @@ describe("Mocked env variables", () => {

await expect(WPVCConfig()).resolves.toStrictEqual({
readme: ["readme.txt", "plugin/readme.txt"],
channel: "stable",
channel: "rc",
assignees: [],
});
});
Expand Down
3 changes: 2 additions & 1 deletion dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10796,9 +10796,10 @@ function normalizeConfig(rawConfig) {
if (typeof rawConfig !== "object" || rawConfig === null) {
throw new ConfigError_1.ConfigError("Invalid config file.");
}
// Default values
const config = {
assignees: [],
channel: "stable",
channel: "rc",
readme: ["readme.txt", "plugin/readme.txt"],
};
if ("readme" in rawConfig) {
Expand Down
3 changes: 2 additions & 1 deletion src/wpvc-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ function normalizeConfig(rawConfig: unknown): Config {
if (typeof rawConfig !== "object" || rawConfig === null) {
throw new ConfigError("Invalid config file.");
}
// Default values
const config: Config = {
assignees: [],
channel: "stable",
channel: "rc",
readme: ["readme.txt", "plugin/readme.txt"],
};
if ("readme" in rawConfig) {
Expand Down

0 comments on commit 0217da4

Please sign in to comment.