Fix asan error in withdrawal fees crawler

src/api/common/include/commonapi.hpp

@@ -37,7 +37,7 @@ class CommonAPI : public ExchangeBase {
   bool queryIsCurrencyCodeFiat(CurrencyCode currencyCode);
 
   /// Query withdrawal fees from crawler sources. It's not guaranteed to work though.
-  WithdrawalFeesCrawler::WithdrawalInfoMaps queryWithdrawalFees(std::string_view exchangeName);
+  const WithdrawalFeesCrawler::WithdrawalInfoMaps &queryWithdrawalFees(std::string_view exchangeName);
 
   void updateCacheFile() const override;
 

src/api/common/include/withdrawalfees-crawler.hpp

@@ -25,7 +25,7 @@ class WithdrawalFeesCrawler {
   using WithdrawalMinMap = std::unordered_map<CurrencyCode, MonetaryAmount>;
   using WithdrawalInfoMaps = std::pair<MonetaryAmountByCurrencySet, WithdrawalMinMap>;
 
-  WithdrawalInfoMaps get(std::string_view exchangeName) { return _withdrawalFeesCache.get(exchangeName); }
+  const WithdrawalInfoMaps& get(std::string_view exchangeName) { return _withdrawalFeesCache.get(exchangeName); }
 
   void updateCacheFile() const;
 

src/api/common/src/commonapi.cpp

@@ -57,7 +57,7 @@ CommonAPI::Fiats CommonAPI::queryFiats() {
 
 bool CommonAPI::queryIsCurrencyCodeFiat(CurrencyCode currencyCode) { return queryFiats().contains(currencyCode); }
 
-WithdrawalFeesCrawler::WithdrawalInfoMaps CommonAPI::queryWithdrawalFees(std::string_view exchangeName) {
+const WithdrawalFeesCrawler::WithdrawalInfoMaps& CommonAPI::queryWithdrawalFees(std::string_view exchangeName) {
   std::lock_guard<std::mutex> guard(_globalMutex);
   return _withdrawalFeesCrawler.get(exchangeName);
 }

src/api/common/src/withdrawalfees-crawler.cpp

@@ -58,7 +58,15 @@ WithdrawalFeesCrawler::WithdrawalFeesCrawler(const CoincenterInfo& coincenterInf
           withdrawalInfoMaps.second.insert_or_assign(cur, withdrawMin);
         }
 
-        _withdrawalFeesCache.set(std::move(withdrawalInfoMaps), lastUpdatedTime, exchangeName);
+        // Warning: we store a std::string_view in the cache, and 'exchangeName' will be destroyed at the end
+        // of this function. So we need to retrieve the 'constant' std::string_view of this exchange (in static memory)
+        // to store in the cache.
+        auto constantExchangeNameSVIt = std::ranges::find(kSupportedExchanges, exchangeName);
+        if (constantExchangeNameSVIt == std::end(kSupportedExchanges)) {
+          throw exception("unknown exchange name {}", exchangeName);
+        }
+
+        _withdrawalFeesCache.set(std::move(withdrawalInfoMaps), lastUpdatedTime, *constantExchangeNameSVIt);
       }
     }
   }