Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wilcoxon NaN values #4402

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fix Wilcoxon NaN values #4402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
231a2ed
Fix Wilcoxon NaN values
soulgalore Jan 13, 2025
16779cb
Merge branch 'main' into fix-nan-wilcoxon
soulgalore Jan 13, 2025
d722413
Merge branch 'main' into fix-nan-wilcoxon
soulgalore Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/plugins/compare/pug/index.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ table
td
a(href=createGraphLink(groupName, metricName))
b #{groupName + '.' + metricName}
if values.statisticalTestU === "N/A" || values.statisticalTestU === "Datasets are identical" || values.statisticalTestU === "No variability"
if values.statisticalTestU === "N/A" || values.statisticalTestU === "Datasets are identical" || values.statisticalTestU === "No variability" || values.statisticalTestU === "Datasets have different lengths"
td #{values.statisticalTestU}
else
td #{h.decimals(values.statisticalTestU)}
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/compare/statistical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def perform_test(test_type, baseline, current, **kwargs):
return None, "Datasets are identical"
else:
return None, "No variability"
if (len(set(baseline)) != len(set(current))) and test_type == 'wilcoxon':
if (len(baseline) != len(current)) and test_type == 'wilcoxon':
return None, "Datasets have different lengths"

if test_type == 'wilcoxon':
Expand Down
Loading