Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include browser benchmark in the baseline data #4015

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Include browser benchmark in the baseline data #4015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 28 additions & 18 deletions lib/plugins/compare/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,24 @@ function getExtras(data) {
return results;
}

function getBrowserMetrics(data) {
const browserMetrics = {
cpuBenchmark: []
};
for (const run of data.browserScripts) {
browserMetrics['cpuBenchmark'].push(run.browser.cpuBenchmark);
}

const results = {};
for (const [metricName, values] of Object.entries(browserMetrics)) {
if (!results.browser) {
results.browser = {};
}
results.browser[metricName] = new Metric(`${metricName}`, values);
}
return results;
}

function getTimings(data) {
const timingMetrics = {
ttfb: [],
Expand Down Expand Up @@ -324,24 +342,16 @@ function getRenderBlocking(data) {
}

export function getMetrics(data) {
const userTimings = getUserTimings(data);
const elementTimings = getElementTimings(data);
const visualMetrics = getVisualMetrics(data);
const rb = getRenderBlocking(data);
const gWV = getGoogleWebVitals(data);
const cdp = getCDPPerformance(data);
const cpu = getCPU(data);
const timings = getTimings(data);
const extras = getExtras(data);
return {
...extras,
...timings,
...cpu,
...cdp,
...visualMetrics,
...gWV,
...rb,
...elementTimings,
...userTimings
...getExtras(data),
...getTimings(data),
...getVisualMetrics(data),
...getGoogleWebVitals(data),
...getRenderBlocking(data),
...getElementTimings(data),
...getUserTimings(data),
...getCPU(data),
...getBrowserMetrics(data),
...getCDPPerformance(data)
};
}