Merge pull request #40 from site-prism/release/v3_4_2

Release/v3 4 2

.rubocop.yml

@@ -50,16 +50,6 @@ Style/TrailingCommaInArrayLiteral:
 Style/AccessModifierDeclarations:
   Enabled: false
 
-# Probably need to look into this, see if we can optimise it down the line
-Metrics/ModuleLength:
-  Exclude:
-    - 'lib/site_prism/dsl.rb'
-
 # Stylistic preference to make the RSpec tests flow better
 RSpec/MessageSpies:
   EnforcedStyle: receive
-
-# This allows one level of nesting inside `shared_examples`
-# This is broken currently!
-RSpec/NestedGroups:
-  Max: 5

.rubocop_todo.yml

@@ -1,11 +1,21 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-01-14 10:33:46 +0100 using RuboCop version 0.75.1.
+# on 2020-01-30 16:46:32 +0100 using RuboCop version 0.75.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 116
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 204
+
 # Offense count: 2
 RSpec/AnyInstance:
   Exclude:
@@ -15,3 +25,7 @@ RSpec/AnyInstance:
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 4
+
+# Offense count: 6
+RSpec/NestedGroups:
+  Max: 5

CHANGELOG.md

@@ -1,6 +1,13 @@
 ## [Unreleased]
 ### Removed
 
+### Added
+
+### Changed
+
+### Fixed
+
+## [3.4.2] - 2020-01-30
 ### Added
 - Simplecov now triggers for both local and CI builds
 ([luke-hill])
@@ -21,6 +28,9 @@
   - All versions up to `< 1` are permitted to future-proof it against further tweaks
 ([luke-hill])
 
+- v13 of `rake` can now be used
+([luke-hill])
+
 ### Fixed
 - Fixed up some RSpec cop offenses & Added reasons for rule definitions
 ([luke-hill])
@@ -986,7 +996,8 @@ impending major rubocop release
 - First release!
 
 <!-- Releases -->
-[Unreleased]: https://github.com/site-prism/site_prism/compare/v3.4.1...master
+[Unreleased]: https://github.com/site-prism/site_prism/compare/v3.4.2...master
+[3.4.2]:      https://github.com/site-prism/site_prism/compare/v3.4.1...v3.4.2
 [3.4.1]:      https://github.com/site-prism/site_prism/compare/v3.4...v3.4.1
 [3.4]:        https://github.com/site-prism/site_prism/compare/v3.3...v3.4
 [3.3]:        https://github.com/site-prism/site_prism/compare/v3.2...v3.3

lib/site_prism/page.rb

@@ -3,7 +3,6 @@
 require 'site_prism/loadable'
 
 module SitePrism
-  # rubocop:disable Metrics/ClassLength
   class Page
     include Capybara::DSL
     include ElementChecker
@@ -167,5 +166,4 @@ def load_html_website(html, &block)
       end
     end
   end
-  # rubocop:enable Metrics/ClassLength
 end

site_prism.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'site_prism-all_there', ['>= 0.3.1', '< 1.0']
 
   s.add_development_dependency 'cucumber', ['~> 3.1']
-  s.add_development_dependency 'rake', ['~> 12.3']
+  s.add_development_dependency 'rake', ['>= 12.3']
   s.add_development_dependency 'rspec', ['~> 3.8']
   s.add_development_dependency 'rubocop', ['~> 0.75.0']
   s.add_development_dependency 'rubocop-performance', ['~> 1.5.1']