Skip to content

Commit

Permalink
MT#55283 annotate some signalling functions
Browse files Browse the repository at this point in the history
These are always called with non-NULL arguments.

Change-Id: I0d7c7d58cc111a19da2116641550b689bac829ff
  • Loading branch information
rfuchs committed Aug 14, 2023
1 parent 2d2c987 commit 9b6cc05
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion daemon/call.c
Original file line number Diff line number Diff line change
Expand Up @@ -3041,6 +3041,7 @@ struct call_subscription *call_get_call_subscription(GHashTable *ht, struct call


/* called with call->master_lock held in W */
__attribute__((nonnull(1, 2, 3)))
int monologue_publish(struct call_monologue *ml, GQueue *streams, struct sdp_ng_flags *flags) {
__call_monologue_init_from_flags(ml, flags);

Expand Down Expand Up @@ -3105,6 +3106,7 @@ int monologue_publish(struct call_monologue *ml, GQueue *streams, struct sdp_ng_
}

/* called with call->master_lock held in W */
__attribute__((nonnull(1, 2, 3, 4)))
static int monologue_subscribe_request1(struct call_monologue *src_ml, struct call_monologue *dst_ml,
struct sdp_ng_flags *flags, unsigned int *index)
{
Expand Down Expand Up @@ -3174,6 +3176,7 @@ static int monologue_subscribe_request1(struct call_monologue *src_ml, struct ca
return 0;
}
/* called with call->master_lock held in W */
__attribute__((nonnull(1, 2, 3)))
int monologue_subscribe_request(const GQueue *srcs, struct call_monologue *dst_ml,
struct sdp_ng_flags *flags)
{
Expand All @@ -3195,6 +3198,7 @@ int monologue_subscribe_request(const GQueue *srcs, struct call_monologue *dst_m
}

/* called with call->master_lock held in W */
__attribute__((nonnull(1, 2, 3)))
int monologue_subscribe_answer(struct call_monologue *dst_ml, struct sdp_ng_flags *flags, GQueue *streams) {
GList *src_ml_it = dst_ml->subscriptions.head;
unsigned int index = 1; // running counter for input/src medias
Expand Down Expand Up @@ -3233,7 +3237,7 @@ int monologue_subscribe_answer(struct call_monologue *dst_ml, struct sdp_ng_flag

__media_init_from_flags(dst_media, NULL, sp, flags);

if (flags && flags->allow_transcoding) {
if (flags->allow_transcoding) {
codec_store_populate(&dst_media->codecs, &sp->codecs, flags->codec_set, true);
codec_store_strip(&dst_media->codecs, &flags->codec_strip, flags->codec_except);
codec_store_offer(&dst_media->codecs, &flags->codec_offer, &sp->codecs);
Expand Down Expand Up @@ -3275,6 +3279,7 @@ int monologue_subscribe_answer(struct call_monologue *dst_ml, struct sdp_ng_flag
}

/* called with call->master_lock held in W */
__attribute__((nonnull(1, 2)))
int monologue_unsubscribe(struct call_monologue *dst_ml, struct sdp_ng_flags *flags) {
for (GList *l = dst_ml->subscriptions.head; l; ) {
GList *next = l->next;
Expand Down

0 comments on commit 9b6cc05

Please sign in to comment.