Skip to content

Commit

Permalink
MT#57761 Do not call restore permissions for set/del commands
Browse files Browse the repository at this point in the history
In the deployment of our lab carrier, we are heavily using   ngcpcfg set
command for example to change the IP addresses of all proxies. The issue is that
execution of a command takes around 1,5 seconds and this seems because every time
"set" is used, we call the check-permissions script, which has some time
penalty to be executed. Most likely nobody uses set quite often, so that is why
the problem was not so visible for a long time.

Change-Id: I47c6c3b88b0f108aadf9d8d9a2b131e0cb76b498
  • Loading branch information
Volodymyr Fedorov committed Jun 28, 2023
1 parent c809811 commit 5823998
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sbin/ngcpcfg
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ case ${1:-} in
init-shared|\
log|\
show|\
set|\
del|\
status)
main_action "$@"
;;
Expand All @@ -175,8 +177,6 @@ case ${1:-} in
push|\
push-parallel|\
services|\
set|\
del|\
patch)
ngcpcfg_update_perms
trap 'ngcpcfg_restore_perms' ERR EXIT
Expand Down

0 comments on commit 5823998

Please sign in to comment.