-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No nnfabrik core #132
Draft
KonstantinWilleke
wants to merge
18
commits into
sinzlab:master
Choose a base branch
from
KonstantinWilleke:no_nnfabrik_core
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
No nnfabrik core #132
KonstantinWilleke
wants to merge
18
commits into
sinzlab:master
from
KonstantinWilleke:no_nnfabrik_core
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update master
update master
update master
update master
update master
update master
update master
update master
update master
update master
Change Documentation along with it. (Arne's comment) |
Collaborator
Author
from nnfabrik import my_nnfabrik
# new default
schema, *tables = my_nnfabrik(schema="my_project_schema")
Dataset, ... = tables
# advanced use case
schemas, *tables = my_nnfabrik(
schema={
'my_name': ["Fabrikant", "Dataset", "Model", "Trainer" ],
'common_name': ["Seed"],
}
)
Dataset, ... = tables |
Please request my review again once you made the changes we talked about yesterday. |
Please request my review once the changes are implemented and the PR can be merged into the main branch without problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is time. Let's get rid of
nnfabrik_core
.This PR would make the use of nnfabrik more straightforward. Now all that is needed to import all main tables would be these lines:
Before that, the cleanest way to import all tables was this: