Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds notification when there’s a new release available #98

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kennethormandy
Copy link
Collaborator

screenshot 2015-05-07 10 32 59

Let people know when there’s a new release of Surge available using update-notifier. The default timing settings are left in place, so you’d only see a notification at most once each day you use Surge, and never until after you’d completed a deploy.

pr

@kennethormandy
Copy link
Collaborator Author

To follow up our previous discussion, the info on when to ask to update again is stored in ~/.config/configstore/update-notifier-surge.yml, along with any other global config for Insight, Update Notifier, and Yo.

The file itself will look something like:

optOut: false
lastUpdateCheck: 1431021283294

Conflicts:
	package.json
pkg: pkg
});

if (!process.stdout.isTTY || isNPM || !notifier.update) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse this if for clarity's sake. When the situation is special, do something special.

if (special && case) {
  takeSpecialAction();
}
// always take this action
next();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants