Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve the workflows #2443

Merged
merged 6 commits into from
Jan 18, 2025
Merged

ci: improve the workflows #2443

merged 6 commits into from
Jan 18, 2025

Conversation

EchoEllet
Copy link
Collaborator

@EchoEllet EchoEllet commented Jan 18, 2025

Minor improvements to CI:

  • Omit all emojis from workflows.
  • Build the example on all platforms instead of only Linux and web.
  • Use the Flutter analyze commenter GitHub action for PRs.
  • Separate main.yml into checks and tests.yml.
  • Not related to this PR: Fixed a WASM compilation issue with flutter_quill_extensions by replacing universal_html with web. I discovered this issue after updating the CI to build the example app with WASM.

Also planning to upload the Android APK of the example to every GitHub release for testing. Done.

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

…r, omit emojis, separate main.yml into checks.yml and tests.yml
@EchoEllet EchoEllet added the no changelog This pull request does not require an update to the changelog, as it does not introduce significant label Jan 18, 2025
@EchoEllet EchoEllet changed the title ci: improve CI ci: improve the workflows Jan 18, 2025
required String margin,
required String alignSelf,
}) {
print('Hello, World'); // Introduce linting issue for testing the new CI.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work as expected.

@EchoEllet EchoEllet marked this pull request as ready for review January 18, 2025 12:23
@EchoEllet EchoEllet merged commit 46b3662 into master Jan 18, 2025
7 checks passed
@EchoEllet EchoEllet deleted the ci/improve branch January 18, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not require an update to the changelog, as it does not introduce significant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant