Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Implementation of OAuth Authorization option to generate bearer token #54

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Feature/Implementation of OAuth Authorization option to generate bearer token #54

wants to merge 7 commits into from

Conversation

f-ocal
Copy link

@f-ocal f-ocal commented May 10, 2019

No description provided.

@cmerrick
Copy link
Contributor

Hi @f-ocal, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @f-ocal!

Thank you for signing the Singer Contribution License Agreement.

luandy64
luandy64 requested changes May 13, 2019
View reviewed changes
Copy link
Contributor

@luandy64 luandy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f-ocal Just a few minor things and I'd be happy to merge this 👍

tap_pipedrive/tap.py Outdated Show resolved Hide resolved
tap_pipedrive/tap.py Outdated Show resolved Hide resolved
tap_pipedrive/tap.py Outdated Show resolved Hide resolved
@luandy64
Copy link
Contributor

@f-ocal I lied, I think there's more work to be done here. Something like this PR is going to have to be implemented. If we only add your PR, then cli.py will throw an error because the OAuth flow doesn't need an API token.

Is this a change you are comfortable making?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luandy64 luandy64 luandy64 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-ocal @cmerrick @luandy64