Support for null/empty org names in notes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In natural (in the wild) Pipedrive usage, we can encounter Organization names that aren't (yet) filled in at the time a note is created on Pipedrive. The current jsonschema rejects such records, which makes the whole sync fail and stop instantly ! Here we're expanding the support by adding null type to organization.name (sub)property.
|
Hi @b-luu, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @b-luu! Thank you for signing the Singer Contribution License Agreement. |
|
Hello @luandy64 Can you have a quick look please ? This is litterally a oneliner and only touches one schema file. Thanks !! Cheers, |
|
Hey @cmerrick What's the process to have this merged ? Thanks for your help! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In natural (in the wild) Pipedrive usage, we can encounter Organization names that aren't (yet) filled in at the time a note is created on Pipedrive.
The current jsonschema rejects such records, which makes the whole sync fail and stop instantly !
Here we're expanding the support by adding null type to organization.name (sub)property.
Manual QA steps
Risks
Rollback steps