Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency version requirements #167

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Conversation

bryantgray
Copy link
Contributor

Description of change

Pin simplejson and backoff to only their major versions

Manual QA steps

  • Verified extraction succeeds with tap using singer-python as dependency

Risks

  • Low. Pinning dependencies to a major version should not cause breaking changes.

Rollback steps

  • revert this branch

setup.py Outdated
'backoff==2.2.1',
'ciso8601',
'backoff>=2.2.1,==2.*',
'ciso8601',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this whitespace, and if so, can we remove it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't wanna block on this in case it's not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a using a tab. I changed it to spaces.

@bryantgray bryantgray merged commit d6f0d20 into master Mar 19, 2024
3 checks passed
@bryantgray bryantgray deleted the update-dependencies branch March 19, 2024 17:45
jesuejunior added a commit to sixcodes/singer-python that referenced this pull request Oct 5, 2024
* parse dev mode argument (singer-io#158)

* parse dev mode argument

* update the short flag for dev mode

Replace `-dev` to `-D`

* Updated the short flag for dev mode

* - remove dev mode short flag

Co-authored-by: RushiT0122 <[email protected]>

* Bump version 5.13.0 (singer-io#160)

* Bump version 5.13.0

* update changelog for dev mode argument parsing

* change versioning to minor version bump

Co-authored-by: RushiT0122 <[email protected]>

* Bump backoff to be compatible with newer python versions (singer-io#165)

* bump backoff for pyton 3.11 compatibility

* update pip version

* try new circleci yml

* remove 'make'

* make pylint happy

* make pylint happy

* make pylint happy again

* backoff version is a breaking change for old python versions

* Changelog update

* Relax dependency version requirements (singer-io#167)

* Relax dependency constraints

* Bump version to `6.0.1`

* pin backoff and simplejson to major version

* Don't allow older versions

* Update changelog

* Pin minumum and major versions

* Make `ensure_ascii` Dynamic with Default Set to `True` in JSON Serialization (singer-io#168)

* add parameter - ensure_ascii to load non ascii characters when set to false

* add unit test for ensuring ascii characters while loading

* update setup and changelog

* Enable copilot usage in PR template according to Qlik policy

* removing simplejson dep and improve dep version

* Adding

* bumping version

* Removing use_decimal param for json.dumps

* Adding a consig to be able to send message to pubsub

* Extracting to a F

* pubsub doesnt expect None as attr

* Parsing state to be used as attr in pubsub

* Set state as stream name when type is state

* feat: supporting a simple entry from lakehouse lib to send messages to a queue

* chore(deps) make jsonschema version flexible

---------

Co-authored-by: Rushikesh Todkar <[email protected]>
Co-authored-by: RushiT0122 <[email protected]>
Co-authored-by: Leslie VanDeMark <[email protected]>
Co-authored-by: Bryant Gray <[email protected]>
Co-authored-by: Sourabh Gandhi <[email protected]>
Co-authored-by: Eivin Giske Skaaren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants