Allow logging configuration to be customized #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Allow logging behavior to be configured at runtime, by supporting a
SINGER_LOGGING_CONF
environment variable. This enables downstream developers to provide their own version oflogging.conf
to match the needs of their projects.Without this change, logging configuration is hard coded in
logging.conf
, which is loaded withinlogger.getLogger()
. This makes it very difficult to change logging settings at runtime. Even taps and targets that attempt to support customization fail to do so properly since multiple invocations oflogger.getLogger()
will simply reload the hard coded settings (target-postgres is an example).Manual QA steps
logging.conf
to a separate file and change the log format to something noticeably differentSINGER_LOGGING_CONF
environment variable to contain the absolute path of your newlogging.conf
Risks
Rollback steps