Incorrect handling of arrays #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2016 14:46
…ve square brackets while parsing query string with array items. Updated tests and readme.
|
This is inconsistent with how the native > querystring.stringify({ foo: ['bar', 'baz'] })
'foo=bar&foo=baz'If the official specification doesn't clarify this behavior then it seems most reasonable to remain consistent with the platform. |
|
This should definitely be behind a option like it is in https://github.com/ljharb/qs. We'd still want the current behaviour as default. |
| @@ -80,11 +81,12 @@ exports.stringify = function (obj, opts) { | |||
| if (val2 === undefined) { | |||
| return; | |||
| } | |||
| var arrayKey = encode(key, encode) + '[]'; | |||
There was a problem hiding this comment.
Add an empty line before this.
|
Closing for lack of response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add square brackets for array items of stringified query string. Remove square brackets while parsing query string with array items. Updated tests and readme. Also related ti issue#66.