fix: default value setting to correctly resolve function return types #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ought to fix #116.
The problem lies in the generic type
OptionsType
.For example, if
pascalCase
is not included in the options, the following type definition would result in the type beingunknow
.Therefore, the type would be
CamelCaseKeys<T, true, unknown, unknown, unknown, "">
as in the issue, resulting in a compile error.With this fix, i change the type to be undefined when there is no key in the options, so the type
WithDefault
works correctly and the type of the default value part is the default value for each.Specifically, it becomes
CamelCaseKeys<T, true>
when the options are as follows.※The above without abbreviation would be
CamelCaseKeys<T, true, false, false, [], [], ''>
.