update create time when remote does not have one #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I uploaded my takeout directly naively, so all the times were incorrect. I updated this tool to be able to detect when the local and remote file are the same, but the local timestamp is *older* then the remote one, which indicates that the local one is better because bad timestamps seem to always be newer than real ones as they are fabricated from when downloaded from google or when uploaded to immich There were other bugs that needed fixing for this--OriginalFileName already had the extension, so I removed the + ext. Also, the updateAsset API seems to have been updated since you added it.
|
Thanks for your PR. I'll review it during the week end |
|
Before going further, have have checked if the problem wasn't created by time zone issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I uploaded my takeout directly naively, so all the times were incorrect. I updated this tool to be able to detect when the local and remote file are the same, but the local timestamp is older then the remote one, which indicates that the local one is better because bad timestamps seem to always be newer than real ones as they are fabricated from when downloaded from google or when uploaded to immich
There were other bugs that needed fixing for this--OriginalFileName already had the extension, so I removed the + ext. Also, the updateAsset API seems to have been updated since you added it.
Interestingly, the timeline does not update correctly after this, but the metadata when you click on an image is correct. I assume this is an immich bug...