silx view: Fixed setting focus at startup when opening a dataset #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Oct 23, 2023
| @@ -453,9 +453,9 @@ def __createCustomNxdataWindow(self, customNxdataWidget): | |||
| layout.addWidget(customNxdataWidget) | |||
| return widget | |||
|
|
|||
| def __h5FileLoaded(self, loadedH5): | |||
| def __h5FileLoaded(self, loadedH5, filename): | |||
There was a problem hiding this comment.
Retrieved from Hdf5TreeModel.sigH5pyObjectLoaded
| @@ -250,7 +250,6 @@ def _closeFileList(fileList): | |||
| """Static method to close explicit references to internal objects.""" | |||
| _logger.debug("Clear Hdf5TreeModel") | |||
| for obj in fileList: | |||
| _logger.debug("Close file %s", obj.filename) | |||
There was a problem hiding this comment.
This was causing issues with the tests since h5py.Dataset do not have a filename attribute.
Comment on lines
+712
to
713
| self.sigH5pyObjectLoaded.emit(h5file, filename) | ||
| self.insertH5pyObject(h5file, row=row, filename=filename) |
There was a problem hiding this comment.
Not sure here why the signal is emitted before inserting the item into the model? 🤷
|
I can't really review the code, but I gave a few tries and it seems to be working. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at opening the vis at startup when providing a data path along with the file to open: closes #3916
To achieve so, this PR adds an extra argument to
Hdf5TreeModel.sigH5pyObjectLoadedin order to pass the full filename used to open the item.