-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlotWidget: Added sigBackendChanged #3890
Conversation
I was thinking of added Usually if you don't do that, the user of the API have to store the backend reference on its side. So i think it could be done without much problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The OpenGLAction
can be improved with this
That's a good idea i have updated the stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I removed OpenGLAction.__state
since it is no longer used.
If it's needed, why not. But this means you'll give back a |
Yes, that is why i am kind of reluctant. In this case we could use 2 signals like |
I agree.
It's fine as it for me. |
Added
sigBackendChanged
toPlotWidget
Related to #3876
Closes #3883
Changelog:
sigBackendChanged
toPlotWidget