Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend cors #578

Merged

Conversation

leonard-henriquez
Copy link
Contributor

Allow CORS for any subdomain which is not currently possible + only mentions "Access-Control-Allow-Credentials" when it's true because that's the recommendation

Copy link
Contributor

@jakthom jakthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, :shipit:

@leonard-henriquez leonard-henriquez changed the base branch from main to 0.18.0 December 10, 2023 21:12
@leonard-henriquez leonard-henriquez merged commit d42ccfc into silverton-io:0.18.0 Dec 12, 2023
2 checks passed
@leonard-henriquez leonard-henriquez deleted the feat/improve-cors-flexbility branch December 12, 2023 15:12
leonard-henriquez added a commit that referenced this pull request Dec 12, 2023
* v0.18.0

* feat: extend cors (#578)

* fix: cors not applied to all routes (#577)

* feat: improve schema read (#576)

* feat: collect ip fingerprint and better tstamp (#575)

* feat: log schema metadata (#574)

* feat: more lambda config options (#573)

* fet: more lambda config options

* chore: remove unused var

* review

---------

Co-authored-by: Léonard Henriquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants