feat: add linting rules for Vue components

[crgwbr]

No description provided.

[crgwbr]

Ping @yokuze

[yokuze]

@crgwbr thanks for doing all of this! A few questions / comments.

[yokuze]

Why are these lines commented out?

[crgwbr]

It's been long enough that I don't remember for sure. But I think my purpose with the commented out lines was to note that we've considered the rule and chosen not to turn it on (vs. a rule not being listed at all, meaning we haven't thought about it yet).

[crgwbr]

It's been long enough that I don't remember for sure. But I think my purpose with the commented out lines was to note that we've considered the rule and chosen not to turn it on (vs. a rule not being listed at all, meaning we haven't thought about it yet).

[yokuze]

Could you open a ticket for us to address the TODO rules here?

[crgwbr]

Done: #72

[yokuze]

I ran these rules against one of our projects and I'm seeing these errors for every file:

1:1   error  Definition for rule 'vue/no-deprecated-v-is' was not found             vue/no-deprecated-v-is
1:1   error  Definition for rule 'vue/no-invalid-model-keys' was not found          vue/no-invalid-model-keys
1:1   error  Definition for rule 'vue/no-this-in-before-route-enter' was not found  vue/no-this-in-before-route-enter
1:1   error  Definition for rule 'vue/require-emit-validator' was not found         vue/require-emit-validator

All of the other rules seem to be executing fine. Any idea why? FWIW, I used npm link to test so maybe that's causing a problem somehow?

[yokuze]

Can we disable the vue/no-multiple-template-root rule? I think it's "on" by default, but multiple template roots are a new feature in Vue 3, are there are legitimate use cases for it.

[crgwbr]

All of the other rules seem to be executing fine. Any idea why? FWIW, I used npm link to test so maybe that's causing a problem somehow?

Yeah, I remember having issues testing this with npm link. I think it's related to differing versions of eslint / eslint-plugin-vue that' only resolve correctly with a real install. If we can get this merged and cut a beta release, I'll work on a MR to test using it.

Can we disable the vue/no-multiple-template-root rule? I think it's "on" by default, but multiple template roots are a new feature in Vue 3, are there are legitimate use cases for it.

✅

[crgwbr]

^ Rebased from master to fix merge conflicts.

[yokuze]

I think this is valuable enough as-is (before addressing the TODOs) for us to cut a beta and let @crgwbr test it out. We need to get something integrated before our Vue codebases continue to grow too much.