-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for synchronizing to a local slave instance #26
base: master
Are you sure you want to change the base?
Conversation
Hi @echernyavskiy I checked the CI error and it is because of the commit messages (sorry, I did not read the rules before I made the initial commits!). What would you like to do on that front? |
Looks like Travis jobs failed because |
@echernyavskiy @CharlieDigital please just rebase and squash all these commits down into one commit, with an appropriate message. More info at: https://github.com/silvermine/silvermine-info/blob/master/commit-history.md |
e3a4ed8
to
cc24efb
Compare
Just checking in to see if there's anything else I can help with here. It seems that the root cause of the failing check is a configuration of the CI environment. |
Sorry, I’m the main developer on this and am on extended holiday. Be back in a couple weeks and hope to look at it then. |
HI @jthomerson - any way we can get this merged into master and added to the latest NPM release? |
@CharlieDigital can you please rebase to merge the two commits so that the build will pass? Alternatively, you can click they button that will allow me to push to your branch so I can update this PR.
Or:
|
@jthomerson added you to the repo. Just want to make sure this gets merged in correctly so other folks looking for similar features have it available :) |
@CharlieDigital @echernyavskiy I just rewrote this PR to (1) not overload the I've done a basic test of syncing a remote table to a local table. I have not been able to do a test of using remote masters and slaves, especially in separate accounts. Is that something one of you could test? Just a smoke test of overall master/slave credentials management? If someone can verify that things are still working as they were before, I'll merge and cut a release. Thanks! |
Purpose
This PR adds support for synchronizing from a remote DynamoDB to a local instance by specifying a
localhost
URL for the parameter--slave-profile
.See #27
Key Changes
cli.js
to check forlocalhost
in the--slave-profile
Synchronizer.js
to add construction of local client as well as selection of correct configuration for DynamoDB