introduce 0.7.0 entrypoint #306

zsluedem · 2024-04-28T03:32:15Z

No description provided.

.github/scripts/install_solc.sh

crates/primitives/src/utils.rs

crates/primitives/src/user_operation/mod.rs

crates/mempool/src/validate/utils.rs

crates/contracts/src/simulation_codes.rs

crates/contracts/src/entry_point.rs

Vid201 · 2024-04-28T21:44:47Z

crates/contracts/src/gen.rs

+abigen!(
+    EntryPointAPI,
+    r#"[
+        struct PackedUserOperation {address sender;uint256 nonce;bytes initCode;bytes callData;bytes32 accountGasLimits;uint256 preVerificationGas;bytes32 gasFees;bytes paymasterAndData;bytes signature;}


Nice, we can get packed struct here!

crates/contracts/src/entry_point.rs

Vid201

Good job, looks good!

I have two questinos:

bundler spec tests are failing in the CI? Is this related to the problem you mentioned in the Telegram group?
we need a way to build docker image for v07? we could expand the docker CI to include branch v07

zsluedem · 2024-04-29T02:47:47Z

Good job, looks good!

I have two questinos:

bundler spec tests are failing in the CI? Is this related to the problem you mentioned in the Telegram group?

we need a way to build docker image for v07? we could expand the docker CI to include branch v07

None of bundlers pass all the tests. There are some erros in the tests itself. You can see result in https://bundler-test-results.erc4337.io/v07/history/history.json. All of them have failures.
Yes. We should do that

Vid201 · 2024-04-29T10:47:15Z

Good job, looks good!
I have two questinos:

bundler spec tests are failing in the CI? Is this related to the problem you mentioned in the Telegram group?

we need a way to build docker image for v07? we could expand the docker CI to include branch v07

None of bundlers pass all the tests. There are some erros in the tests itself. You can see result in https://bundler-test-results.erc4337.io/v07/history/history.json. All of them have failures.

Yes. We should do that

Hmm, ok. This PR looks good now, but it would be good to resolve these 2 things in this PR.

I see, but bundlers are failing only a few tests (less than 10), but in our CI (https://github.com/silius-rs/silius/actions/runs/8875058214/job/24364088083) 100 tests fail.
update docker CI

zsluedem · 2024-04-30T04:14:07Z

Good job, looks good!
I have two questinos:

bundler spec tests are failing in the CI? Is this related to the problem you mentioned in the Telegram group?

we need a way to build docker image for v07? we could expand the docker CI to include branch v07

None of bundlers pass all the tests. There are some erros in the tests itself. You can see result in https://bundler-test-results.erc4337.io/v07/history/history.json. All of them have failures.

Yes. We should do that

Hmm, ok. This PR looks good now, but it would be good to resolve these 2 things in this PR.

I see, but bundlers are failing only a few tests (less than 10), but in our CI (https://github.com/silius-rs/silius/actions/runs/8875058214/job/24364088083) 100 tests fail.

update docker CI

OK. Forget to update some args. Locally I got like 6 tests failing

…r image publish

.github/workflows/docker.yml

bundler-spec-tests/docker-compose.yml

zsluedem · 2024-05-07T06:53:59Z

@Vid201 It should be ready now.

Vid201

GJ, looks good now!

zsluedem requested a review from Vid201 as a code owner April 28, 2024 03:32

zsluedem force-pushed the feat/v0.7.0 branch from d2ea841 to 0466d79 Compare April 28, 2024 03:43

introduce 0.7.0 entrypoint

27bbed1

zsluedem force-pushed the feat/v0.7.0 branch from 0466d79 to 27bbed1 Compare April 28, 2024 05:59