Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.4.4 -- Also push a {major} version tag (e.g. 6) #174

Merged
merged 6 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
* @silinternational/developers
*.php @silinternational/php-devs
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

---

### Feature PR Checklist
### PR Checklist
- [ ] Put version number in PR title (e.g. `Release x.y.z - Summary of changes`)
- [ ] Documentation (README, etc.)
- [ ] Unit tests created or updated
- [ ] Run `make composershow`
4 changes: 3 additions & 1 deletion .github/workflows/test-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
name: Build and Publish
needs: tests
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags')
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down Expand Up @@ -47,6 +48,7 @@ jobs:
type=ref,event=branch
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}

- name: Build and push Docker image to Docker Hub
uses: docker/build-push-action@v5
Expand All @@ -67,4 +69,4 @@ jobs:
ghcr.io/${{ github.repository }}:${{ github.ref_name }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
GITHUB_REF_NAME=${{ github.ref_name }}
GITHUB_REF_NAME=${{ github.ref_name }}
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ protected function generateDummyPassword()
public function anActiveUserExists()
{
$newUser = $this->idBroker->createUser($this->testUserData);
Assert::assertTrue($newUser->getActive() === 'yes');
Assert::assertNotNull($newUser);
}

Expand Down