Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Support for Fulcio Client Credentials Flow, and Argument to Set Flow Explicitly #3571

Closed
wants to merge 0 commits into from

Conversation

nkreiger
Copy link
Contributor

@nkreiger nkreiger commented Mar 2, 2024

Summary

Implements this:

sigstore/sigstore#1619


It looks like the flag was also missing from the CLI ko.KeyOpts to set the fulcio flow explicitly. Should be 100% backwards compatible because the default was always an empty string.

Release Note

  • Command Flag Addition - --fulcio-auth-flow to explicitly set the fulcio authentication flow
  • API Addition, support for --fulcio-auth-flow=client_credentials as an authentication flow. Requires the Client ID and Client Secret.

Documentation

cosign sign --fulcio_url=<url> --fulcio-auth-flow=client_credentials --client-secret=<secret file> --client-id=sigstore

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 19.35484% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 40.41%. Comparing base (628df78) to head (ab8b0cd).
Report is 37 commits behind head on main.

❗ Current head ab8b0cd differs from pull request most recent head 2466c15. Consider uploading reports for the commit 2466c15 to get more accurate results

Files Patch % Lines
cmd/cosign/cli/options/fulcio.go 0.00% 3 Missing ⚠️
cmd/cosign/cli/signblob.go 0.00% 2 Missing and 1 partial ⚠️
...ernal/pkg/cosign/fulcio/fulcioroots/fulcioroots.go 0.00% 3 Missing ⚠️
cmd/cosign/cli/fulcio/fulcio.go 0.00% 2 Missing ⚠️
cmd/cosign/cli/public_key.go 0.00% 1 Missing and 1 partial ⚠️
cmd/cosign/cli/sign.go 0.00% 1 Missing and 1 partial ⚠️
cmd/cosign/cli/attest.go 0.00% 1 Missing ⚠️
cmd/cosign/cli/attest_blob.go 0.00% 1 Missing ⚠️
cmd/cosign/cli/env.go 0.00% 0 Missing and 1 partial ⚠️
cmd/cosign/cli/generate/generate.go 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3571      +/-   ##
==========================================
+ Coverage   40.10%   40.41%   +0.31%     
==========================================
  Files         155      155              
  Lines       10044    10056      +12     
==========================================
+ Hits         4028     4064      +36     
+ Misses       5530     5503      -27     
- Partials      486      489       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkreiger nkreiger force-pushed the main branch 3 times, most recently from bc34128 to 7c3f40a Compare March 3, 2024 14:43
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Were you able to test this out locally to confirm it's working as expected?

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you rebase against main? There's a bunch of extra commits in this PR

@nkreiger
Copy link
Contributor Author

nkreiger commented Mar 7, 2024

Thanks! Were you able to test this out locally to confirm it's working as expected?

yes, I was!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants