Skip to content

Commit

Permalink
Merge pull request #11 from signetlabdei/overload_fix
Browse files Browse the repository at this point in the history
Overloaded method fix in QUIC BBR
  • Loading branch information
mychele authored Nov 13, 2020
2 parents 649264b + 3ecb79c commit 29d34ee
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
12 changes: 12 additions & 0 deletions model/quic-bbr.cc
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,8 @@ QuicBbr::UpdateBtlBw (Ptr<QuicSocketState> tcb, const struct RateSample * rs)
}
}



void
QuicBbr::UpdateModelAndState (Ptr<QuicSocketState> tcb, const struct RateSample * rs)
{
Expand Down Expand Up @@ -608,6 +610,16 @@ QuicBbr::CongControl (Ptr<QuicSocketState> tcb, const struct RateSample *rs)
UpdateControlParameters (tcb, rs);
}

void
QuicBbr::CongControl (Ptr<TcpSocketState> tcb,
const TcpRateOps::TcpRateConnection &rc,
const TcpRateOps::TcpRateSample &rs)
{
NS_LOG_FUNCTION (this << tcb);
NS_UNUSED (rc);
NS_UNUSED (rs);
}

void
QuicBbr::CongestionStateSet (Ptr<TcpSocketState> tcb,
const TcpSocketState::TcpCongState_t newState)
Expand Down
12 changes: 10 additions & 2 deletions model/quic-bbr.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */
/*
* Copyright (c) 2018 NITK Surathkal, 2020 SIGNET Lab, Department of
* Information Engineering, University of Padova
* Copyright (c) 2018 NITK Surathkal,
* Copyright (c) 2020 SIGNET Lab, Department of Information Engineering,
* University of Padova
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
Expand Down Expand Up @@ -105,6 +106,13 @@ class QuicBbr : public QuicCongestionOps
virtual void IncreaseWindow (Ptr<TcpSocketState> tcb,
uint32_t segmentsAcked);
virtual Ptr<TcpCongestionOps> Fork ();

/**
* \brief Unused function, added here to avoid overloading the one in TcpCongestionOps
*/
virtual void CongControl (Ptr<TcpSocketState> tcb,
const TcpRateOps::TcpRateConnection &rc,
const TcpRateOps::TcpRateSample &rs);

protected:
void OnPacketAcked (Ptr<TcpSocketState> tcb, Ptr<QuicSocketTxItem> ackedPacket);
Expand Down

0 comments on commit 29d34ee

Please sign in to comment.