-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI pipeline and bump supported ns-3 version to ns-3.43 #173
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #173 +/- ##
===========================================
+ Coverage 76.25% 77.68% +1.43%
===========================================
Files 69 66 -3
Lines 5436 6844 +1408
===========================================
+ Hits 4145 5317 +1172
- Misses 1291 1527 +236 ☔ View full report in Codecov by Sentry. |
Note: The decrease in test coverage signaled by Codecov is expected, as now we run coverage checks with the |
3ee4dc7
to
5a205d5
Compare
151eb55
to
9b41524
Compare
fd80ef8
to
7d5b4f0
Compare
Fixed Codecov CI error by extending test coverage to buildings model via an example's parameter in tests |
Ns-3.43 introduces the following changes to the CI pipeline:
The following maintenance changes to this repo's CI are also applied:
Notable changes to module files brought by ns-3.43:
Ns-3.43 also removes dependency of the
propagation
module's tests on theapplications
module. In the past, the lowest compilation time could only be achieved via--enable-modules "lorawan;applications"
, as we did in our CI jobs. Now configuring ns-3 with just--enable-modules lorawan
still leads to all tests passing but with a lower compilation time. Yay! See this ns-3 issue for more details.