Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolver with Maven 4 #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix resolver with Maven 4 #378

wants to merge 1 commit into from

Conversation

gnodet
Copy link

@gnodet gnodet commented Dec 22, 2024 •
edited
Loading

@lprimak Lenny, could you check if that helps for your use cases ?

@cstamas
Copy link
Contributor

cstamas commented Dec 22, 2024

This is the missing piece from #375 !
Note: that PR also fixes session creation, as it uses MIMA context (that in Maven4 contains "real" context)

@lprimak
Copy link
Contributor

lprimak commented Dec 22, 2024

I see no effect at all, positive or negative. This could not hurt, but I don't see it helping other than guessing that it could improve performance somewhat.

@lprimak
Copy link
Contributor

lprimak commented Jan 10, 2025

@gnodet please un-draft this

@gnodet gnodet marked this pull request as ready for review January 15, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lprimak lprimak lprimak approved these changes

@cstamas cstamas cstamas approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnodet @cstamas @lprimak