Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out the downloadNecessaryHLS code #198

Merged
merged 1 commit into from
Aug 2, 2023
Merged

comment out the downloadNecessaryHLS code #198

merged 1 commit into from
Aug 2, 2023

Conversation

Leslie-Wong-H
Copy link
Member

@Leslie-Wong-H Leslie-Wong-H commented Aug 2, 2023

Fix #197

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #198 (f81226a) into main (70e5143) will decrease coverage by 2.40%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   75.00%   72.60%   -2.40%     
==========================================
  Files          12       12              
  Lines         436      387      -49     
  Branches       91       84       -7     
==========================================
- Hits          327      281      -46     
+ Misses        104      101       -3     
  Partials        5        5              
Flag Coverage Δ
unittests 72.60% <ø> (-2.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lib/generate-video-preview.js 83.33% <ø> (-9.40%) ⬇️

@Leslie-Wong-H Leslie-Wong-H added the bug Something isn't working label Aug 2, 2023
@Leslie-Wong-H Leslie-Wong-H merged commit d085922 into main Aug 2, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote S3 HLS error - Option headers not found.
1 participant