fix: onboarding button wording with ppcp check #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstegmeyer
approved these changes
Feb 6, 2025
cyl3x
deleted the
fix/onboarding-button-wording-on-wrong-merchant-integrations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onboarding button component can do live & sandbox, but merchant information is only loaded based on the sandbox toggle. So if you only have sandbox credentials, but the sandbox is set to live, the merchant information for live will of course be loaded - i.e.
canPPCPwill be set to false. If you now create a sandbox button for the payment method card, it will not say 'Change sandbox account' but 'Start new onboarding', even though validate credentials are stored.=> the button should only check
canPPCPif merchant information is loaded for the correct type.