Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds index on the valid_until column of the short_urls table #2113

Conversation

marijnvandevoorde
Copy link
Contributor

@marijnvandevoorde marijnvandevoorde commented Apr 25, 2024

The idea is to improve the performance of the DeleteExpiredShortUrlsCommand

…ve the performance of the DeleteExpiredShortUrlsCommand
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (163244f) to head (814c9f0).
Report is 282 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2113   +/-   ##
==========================================
  Coverage      96.11%   96.11%           
  Complexity      1424     1424           
==========================================
  Files            263      263           
  Lines           5116     5116           
==========================================
  Hits            4917     4917           
  Misses           199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya
Copy link
Member

acelaya commented Dec 22, 2024

I'm going to close this for now, as I was not able to see a clear performance improvement back when this was provided, so I need to do a bit more testing.

Also, the migration is no longer chronologically ordered, as other migrations have been added since.

@acelaya acelaya closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants