refactor(ad): refactor ad and add documentation #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for ohplayer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @shiyiya Could you please review the PR and merge it into the main branch? After that, could you also update the npm package? I'm waiting to get the latest locales and the ad changes so I can proceed with implementing them in my project. Thanks |
|
pls open ✅ allow edits from maintainer |
|
@shiyiya |
|
Please check now, if you can edit |
|
Could you please update the npm package? Alternatively, could you let me
know when it will be updated? I need the latest changes for my project and
am currently waiting on them.
Thanks for your help!
…On Mon, Jan 6, 2025 at 9:06 AM CY ***@***.***> wrote:
Merged #148 <#148> into main.
—
Reply to this email directly, view it on GitHub
<#148 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APMXIOJVBNZL7FICHCVFB7D2JIB4HAVCNFSM6AAAAABUT7E6ZSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHAZDCMJWHA4DCOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Already published :) |
|
Thank you
…On Mon, Jan 6, 2025, 9:22 AM CY ***@***.***> wrote:
1.2.38-beta.0
***@***.***/core/v/1.2.38-beta.0>
1.0.15-beta.0
***@***.***/plugins/v/1.0.15-beta.0>
Already published :)
—
Reply to this email directly, view it on GitHub
<#148 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APMXIOKMKZJUXC5RPJJFOZD2JID2DAVCNFSM6AAAAABUT7E6ZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZSGI3TENJZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.