Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scaling the display scale of arc segments #70

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

rkyle35242
Copy link
Member

@rkyle35242 rkyle35242 commented Mar 25, 2024

Requirements:

  1. keep existing implementations intact
  2. support a segment value to adjust the size of the arc segments while still supporting segment[].scale

Before/After screenies include the below segments:

  const _segments = [
    {
      scale: 0.94,
      arcDegreeScale: 0.5,
      filledColor: firstSegmentFilledColor,
      emptyColor: firstSegmentEmptyColor,
      data: { label: firstSegmentLabel }
    },
    {
      scale: 0.02,
      arcDegreeScale: 0.3,
      filledColor: secondSegmentFilledColor,
      emptyColor: secondSegmentEmptyColor,
      data: { label: secondSegmentLabel }
    },
    {
      scale: 0.02,
      arcDegreeScale: 0.1,
      filledColor: thirdSegmentFilledColor,
      emptyColor: thirdSegmentEmptyColor,
      data: { label: thirdSegmentLabel }
    },
    {
      scale: 0.02,
      arcDegreeScale: 0.1,
      filledColor: fourthSegmentFilledColor,
      emptyColor: fourthSegmentEmptyColor,
      data: { label: fourthSegmentLabel }
    }
  ];
Before After
image image

Copy link
Collaborator

@jkhusanov jkhusanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkyle35242 rkyle35242 merged commit c310637 into development Apr 9, 2024
3 checks passed
@rkyle35242 rkyle35242 deleted the support-segment-arc-degree-scale branch April 9, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants