Update to PHP7.4 #127
Merged
Update to PHP7.4 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakkulkarni
approved these changes
Dec 26, 2019
Jamesking56
approved these changes
Jan 3, 2020
|
Anyone here who approved this PR tested it out yet? I’ve only lightly tested it but I have a fresh kid at home and less time for the next month or so :D |
|
Docker is just rebuilding, will comment the result shortly |
Jamesking56
approved these changes
Jan 3, 2020
|
thanks!
…On Fri, Jan 3, 2020 at 16:16 James King ***@***.***> wrote:
***@***.**** approved this pull request.
Working for me on my project. ./vessel php -v shows PHP 7.4.1 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#127?email_source=notifications&email_token=AADSDUYFP3LNRDTALF554GLQ362NJA5CNFSM4JTWDDKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQVAM5I#pullrequestreview-338298485>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADSDU6JQ5GKN3FYELEQM3DQ362NJANCNFSM4JTWDDKA>
.
|
|
Tested it from my side too! |
|
@fideloper: mate, this PR will ensure all dependencies are upto date: #131 |
|
@fideloper Can you do a new release so I can pull the latest code with php7.4? |
|
Yep, tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like xDebug is ready for release already too!