Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

絵文字が見つからないときのTextのstyleを修正 #244

Merged

Conversation

poppingmoon
Copy link
Contributor

カスタム絵文字の読み込み時にエラーが起きたときや、存在しないカスタム絵文字が参照されたときに表示される :name: のような文字がMfmTextに与えられたTextStyleに従っていなかったのを修正しました

@codecov-commenter
Copy link

Codecov Report

Merging #244 (f519c3a) into master (7b0e8b8) will increase coverage by 0.00%.
The diff coverage is 88.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   24.92%   24.93%           
=======================================
  Files         198      198           
  Lines        9010     9009    -1     
=======================================
  Hits         2246     2246           
+ Misses       6764     6763    -1     
Files Changed Coverage Δ
lib/view/common/misskey_notes/mfm_text.dart 37.58% <ø> (ø)
lib/view/common/misskey_notes/custom_emoji.dart 87.50% <88.23%> (+1.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shiosyakeyakini-info shiosyakeyakini-info merged commit 8448154 into shiosyakeyakini-info:master Aug 12, 2023
1 check passed
@shiosyakeyakini-info
Copy link
Owner

マージしました!ありがとうございます!

@poppingmoon poppingmoon deleted the emoji-style branch August 13, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants