Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): remove redundant step #54

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix(tests): remove redundant step #54

merged 1 commit into from
Jan 16, 2025

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Jan 16, 2025

Summary by Sourcery

Remove the redundant step of exporting dependencies to requirements.txt.

CI:

  • Remove redundant dependency export step.

Tests:

  • Simplify test dependencies installation.

Copy link

sourcery-ai bot commented Jan 16, 2025

Reviewer's Guide by Sourcery

This pull request removes the redundant step of exporting dependencies to requirements.txt and then installing from it. Instead, it installs the dependencies directly from the project and Poetry's managed dependencies.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the redundant dependency export and install steps.
  • Removed the step that exports the project dependencies to requirements.txt.
  • Removed the step that installs dependencies from requirements.txt.
  • Modified the dependency installation step to install directly from the project's setup and Poetry's managed dependencies using pip install .
.github/workflows/run-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shini4i - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shini4i shini4i merged commit 02f0413 into main Jan 16, 2025
4 checks passed
@shini4i shini4i deleted the fix/test branch January 16, 2025 16:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (a5faea5) to head (62e003d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   65.44%   65.44%           
=======================================
  Files           3        3           
  Lines         246      246           
=======================================
  Hits          161      161           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants