Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sora 2024.2 対応 #46

Merged
merged 16 commits into from
Dec 18, 2024
Merged

Sora 2024.2 対応 #46

merged 16 commits into from
Dec 18, 2024

Conversation

tnamao
Copy link
Collaborator

@tnamao tnamao commented Dec 18, 2024

ListClusterNodes API のリクエストパラメータの変更により Sora 2024.2 では以前の expoter でクラスターの統計情報が取得不可になります

変更履歴

  • [CHANGE] クラスターメトリクスを収集する際の ListClusterNodes API の呼び出し時にリクエストパラメータの指定を削除する

    • 破壊的変更になるため、バージョンアップの際に注意してください
    • Sora 2024.2.0 での include_all_known_nodes パラメータ廃止への対応です
    • Sora 2023.2 以前と Sora 2024.1 以降で、exporter が返すメトリクスの結果が変わります
    • @tnamao
  • [ADD] SRTP 統計情報を追加する

    • Sora API の GetStatsReport API から取得可能な SRTP 統計情報を以下のメトリクス名で追加する
      • sora_srtp_received_packets_total
      • sora_srtp_received_bytes_total
      • sora_srtp_sent_packets_total
      • sora_srtp_sent_bytes_total
      • sora_srtp_decrypted_packets_total
      • sora_srtp_decrypted_bytes_total
    • @tnamao
  • [ADD] SCTP 統計情報を追加する

    • Sora API の GetStatsReport API から取得可能な SCTP 統計情報を以下のメトリクス名で追加する
      • sora_sctp_received_packets_total
      • sora_sctp_received_bytes_total
      • sora_sctp_sent_packets_total
      • sora_sctp_sent_bytes_total
    • @tnamao
  • [ADD] 無視されたウェブフック数の統計情報を追加する

    • Sora API の GetStatsReport API から取得可能な無視されたウェブフック数を以下のメトリクス名で追加する
    • 既存の以下のメトリクスの state ラベルに ignored で値を返す
      • sora_event_webhook_total
      • sora_session_webhook_total
      • sora_stats_webhook_total
    • @tnamao
  • [UPDATE] 依存パッケージを更新する

    • prometheus/client_golang 1.19.1 => 1.20.5
    • prometheus/common 0.54.0 => 0.61.0
    • prometheus/exporter-toolkit 0.11.0 => 0.13.2

This pull request includes significant changes to the metrics collection and reporting features of the project. The primary focus is on adding new metrics for SRTP and SCTP, updating existing webhook metrics, and removing unnecessary request parameters for cluster node metrics. Additionally, several dependencies have been updated.

Metrics Additions and Updates:

  • Added SRTP metrics to the Collector:

    • sora_srtp_received_packets_total
    • sora_srtp_received_bytes_total
    • sora_srtp_sent_packets_total
    • sora_srtp_sent_bytes_total
    • sora_srtp_decrypted_packets_total
    • sora_srtp_decrypted_bytes_total [1] [2] [3] [4] [5] [6] [7]
  • Added SCTP metrics to the Collector:

    • sora_sctp_received_packets_total
    • sora_sctp_received_bytes_total
    • sora_sctp_sent_packets_total
    • sora_sctp_sent_bytes_total [1] [2] [3] [4] [5] [6] [7]
  • Updated webhook metrics to include ignored webhooks:

    • sora_event_webhook_total
    • sora_session_webhook_total
    • sora_stats_webhook_total [1] [2] [3] [4] [5]

Codebase Simplification:

  • Removed the SoraListClusterNodesRequest struct and associated request parameters for cluster node metrics collection [1] [2]

Dependency Updates:

  • Updated several dependencies in go.mod:
    • prometheus/client_golang from 1.20.4 to 1.20.5
    • prometheus/common from 0.59.1 to 0.61.0
    • prometheus/exporter-toolkit from 0.13.0 to 0.13.2
    • Various golang.org/x packages [1] [2]

@tnamao
Copy link
Collaborator Author

tnamao commented Dec 18, 2024

リリース準備のためマージします

@tnamao tnamao merged commit 3ba6d27 into develop Dec 18, 2024
1 check passed
@tnamao tnamao deleted the feature/sora-2024.2 branch December 18, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant