Feature/fix npm pkg e2e test #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving the end-to-end testing, adding version information, and ensuring compatibility with specific versions of the
sora-js-sdk. The most important changes include modifications to the GitHub Actions workflow, updates to the example messaging HTML and TypeScript files, and enhancements to the test files to check for specific SDK versions.Improvements to GitHub Actions Workflow:
.github/workflows/npm-pkg-e2e-test.yml: Modified the paths to include thetestsdirectory and removed thecontinue-on-erroroption.Enhancements to Example Files:
examples/messaging/index.html: Added a new section to display thesora-js-sdkversion.examples/messaging/main.mts: Added code to retrieve and display thesora-js-sdkversion.Enhancements to Test Files:
tests/helper.ts: Added a helper function to compare version strings.tests/message_header.spec.tsandtests/messaging.spec.ts: Updated tests to include version checks forsora-js-sdkand conditionally skip tests if the version is below2024.2.0. [1] [2] [3] [4]